Skip to content

Don't attempt to install modules into test cluster more than once #121833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 5, 2025
Merged

Don't attempt to install modules into test cluster more than once #121833

merged 1 commit into from
Feb 5, 2025

Conversation

@mark-vieira
Copy link
Contributor

@mark-vieira mark-vieira commented Feb 5, 2025

When installing modules that extend other modules, it's possible to install the same module multiple times. This can cause issues if overrides are specified for that module. Avoid doing this by skipping module installation for extended modules if they've already been installed.

@mark-vieira mark-vieira added >test Issues or PRs that are addressing/adding tests :Delivery/Build Build or test infrastructure v8.19.0 v9.0.1 labels Feb 5, 2025
@elasticsearchmachine elasticsearchmachine added Team:Delivery Meta label for Delivery team v9.1.0 labels Feb 5, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Feb 5, 2025

Pinging @elastic/es-delivery (Team:Delivery)

rjernst
rjernst approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mark-vieira mark-vieira enabled auto-merge (squash) February 5, 2025 22:10
@mark-vieira mark-vieira merged commit 56cac1b into elastic:main Feb 5, 2025
17 checks passed
mark-vieira added a commit to mark-vieira/elasticsearch that referenced this pull request Feb 6, 2025
@mark-vieira
Don't attempt to install modules into test cluster more than once (el…
e2b91e6 
…astic#121833)

(cherry picked from commit 56cac1b)
This was referenced Feb 6, 2025
Merged
Merged
mark-vieira added a commit to mark-vieira/elasticsearch that referenced this pull request Feb 6, 2025
@mark-vieira
Don't attempt to install modules into test cluster more than once (el…
246e73b 
…astic#121833)

(cherry picked from commit 56cac1b)
mark-vieira added a commit to mark-vieira/elasticsearch that referenced this pull request Feb 6, 2025
@mark-vieira
Don't attempt to install modules into test cluster more than once (el…
a3c2c6a 
…astic#121833)

(cherry picked from commit 56cac1b)
@mark-vieira mark-vieira mentioned this pull request Feb 6, 2025
Merged
mark-vieira added a commit to mark-vieira/elasticsearch that referenced this pull request Feb 6, 2025
@mark-vieira
Don't attempt to install modules into test cluster more than once (el…
9f88d98 
…astic#121833)

(cherry picked from commit 56cac1b)
@mark-vieira mark-vieira mentioned this pull request Feb 6, 2025
Merged
mark-vieira added a commit to mark-vieira/elasticsearch that referenced this pull request Feb 6, 2025
@mark-vieira
Don't attempt to install modules into test cluster more than once (el…
2263e7e 
…astic#121833)

(cherry picked from commit 56cac1b)
@mark-vieira mark-vieira mentioned this pull request Feb 6, 2025
Merged
@mark-vieira
Copy link
Contributor Author

mark-vieira commented Feb 6, 2025

💚 All backports created successfully

Status Branch Result
✅ 8.x
✅ 9.0
✅ 8.18
✅ 8.17
✅ 8.16

Questions ?

Please refer to the Backport tool documentation

elasticsearchmachine pushed a commit that referenced this pull request Feb 6, 2025
@mark-vieira
Don't attempt to install modules into test cluster more than once (#1…
0b865d4 
…21833) (#121863)

(cherry picked from commit 56cac1b)
elasticsearchmachine pushed a commit that referenced this pull request Feb 6, 2025
@mark-vieira
Don't attempt to install modules into test cluster more than once (#1…
c94dbc6 
…21833) (#121859)

(cherry picked from commit 56cac1b)
elasticsearchmachine pushed a commit that referenced this pull request Feb 6, 2025
@mark-vieira
Don't attempt to install modules into test cluster more than once (#1…
ca55558 
…21833) (#121861)

(cherry picked from commit 56cac1b)
elasticsearchmachine pushed a commit that referenced this pull request Feb 6, 2025
@mark-vieira
Don't attempt to install modules into test cluster more than once (#1…
2846f64 
…21833) (#121862)

(cherry picked from commit 56cac1b)
elasticsearchmachine pushed a commit that referenced this pull request Feb 6, 2025
@mark-vieira
Don't attempt to install modules into test cluster more than once (#1…
a0f77e7 
…21833) (#121860)

(cherry picked from commit 56cac1b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rjernst rjernst rjernst approved these changes

Assignees

No one assigned

Labels

:Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team >test Issues or PRs that are addressing/adding tests v8.19.0 v9.0.1 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mark-vieira @elasticsearchmachine @rjernst